Manually test a theme function to twig template conversion

Final / Up to date -- AWAITING PEER REVIEW
Description: 
In this lesson you will manually test the HTML output of conversions.
Overview: 

In this lesson you will review and possibly revise a patch for Twig, currently in the issue queues of drupal.org. You will make notes of your observations during each step of the lesson. You will use these notes to create your Patch Review.
You do NOT need be a Drupal expert to test a theme function to twig template conversion. Simply choose a patch that matches your level of ability. Even the smallest, most basic patches need to be reviewed and possibly revised.

Prerequisites: 
  • a clean checkout of the Drupal code base in which the issue appears (instructions)
  • the ability to apply and test patches (instructions)
  • at least a beginner-level familiarity with PHP and the Drupal API
Steps: 
  1. Make sure you are on a clean checkout of 8.x HEAD
  2. Check the issue summary for a "How to test this code" section:
    • If there is no "How to test this code" section, please find out how to test it, and then create one :)
  3. Test the expected behavior before the patch is applied:
    • Navigate to each page as instructed
    • take a screenshot of (or copy and paste) the source of the specific part of the page that will be changed by the patch
    • Label the screensot "before-whatever.png"
  4. Apply the patch
  5. Test the patch as usual
  6. Test the expected behavior after the patch is applied:
    • Navigate to each page as instructed (again)
    • take a screenshot of (or copy and paste) the source of the specific part of the page that has been changed by the patch
    • Label the screensot "after-whatever.png"
  7. Compare the before & after screenshots, they should be exactly the same with the exception whitespace.
  8. Post your review as a comment in the issue queue, noting any changes in the markup screenshots.
  9. Post your screensthots as attachments to your comment.

More up-to-date instructions may be found here: https://drupal.org/node/2048869

Lesson tags: