In this lesson you will review and possibly revise a REAL drupal patch currently in the issue queues of drupal.org. You will make notes of your observations during each step of the lesson. You will use these notes to create your Patch Review.
You do NOT need be a drupal expert to review and revise patches. Simply choose a patch that matches your level of ability. Even the smallest, most basic patches need to be reviewed and possibly revised. These include patches that remove extra whitespaces from existing code, patches that correct typos in a function's comment, and patches that make very simple code corrections.
.patch Search Tips:
Familiarize yourself with drupal.org's Advance Search pages, search options, and sort-table-on-heading features. In particular, Drupal Core has its own Advanced Search Page with additional search options (“Version” and “Component”) that are NOT available from the All Projects Advanced Search Pages. The more you can fine-tune your issue queue searches, the easier it will be to find patches in need of review that are both interesting and within your skill level.
Patch Reviewing and Revising Tools:
Dreditor (a browser plugin for reviewing patches and more)
Coder module (an automated way of checking for code standards compliance)
Testing (Simpletest) module
PARevview (still D7)
How to Work the Issue Queue - http://drupal.org/node/945492
Diaries of a Core Maintainer #5: The 6-pass patch review - http://webchick.net/6-pass-patch-reviews
Drupal Coding Standards - http://drupal.org/coding-standards
Doxygen and comment formatting conventions - http://drupal.org/node/1354
Code Review of Full Project Applications - http://groups.drupal.org/code-review
Increasing efficiency in manual code reviews - http://groups.drupal.org/node/184389
Writing Secure Code - http://drupal.org/writing-secure-code
Programming Best Practices - http://drupal.org/node/287350
Priority Levels of Drupal - http://drupal.org/node/45111
Clean Code: A Handbook of Agile Software Craftmanship, by Robert C. Martin
This Code Stinks! - PDF: http://london2011.drupal.org/sites/default/files/Code%20Smells_0.pdf
HOWTO: Submit tests with your patch - http://groups.drupal.org/node/11020
Unit Testing with Simpletest - http://drupal.org/node/811254