Review and revise Twig patches

Draft (work in progress) -- AWAITING PEER REVIEW
Description: 
Learn to review and revise Twig patches submitted to the drupal.org issue queue.
Overview: 

In this lesson you will review and possibly revise a patch for Twig, currently in the issue queues of drupal.org. You will make notes of your observations during each step of the lesson. You will use these notes to create your Patch Review.

You do NOT need be a drupal expert to review and revise patches. Simply choose a patch that matches your level of ability. Even the smallest, most basic patches need to be reviewed and possibly revised. These include patches that remove extra whitespaces from existing code, patches that correct typos in a function's comment, and patches that make very simple code corrections.

Prerequisites: 
  • a clean checkout of the Drupal code base in which the issue appears (instructions)
  • the ability to apply and test patches (instructions)
  • at least a beginner-level familiarity with PHP and the Drupal API
  • a basic knowledge on how to Review and revise patches (instructions)
  • your favorite note-taking application
Steps: 

Quick Outline:

  1. Search for a Twig patch to review
  2. Review the patch's Twig coding-standards
  3. Review the issue
  4. Review the patch
  5. Write your review
  6. Review your review
  7. Post your review

Detailed Steps:

  1. Search for a Twig patch to review
    1. Login to drupal.org
    2. Click on one of the search links below.
      1. Search All Projects for a recent patch that Needs Review and is tagged with Twig
        https://drupal.org/project/issues/search?text=.patch&projects=&assigned=...
      2. Search All Projects for a recent patch that Needs Work and is tagged with Twig
        https://drupal.org/project/issues/search?text=.patch&projects=&assigned=...
      3. Note! This is not necessarily only Twig-code, it could contain some PHP also.

  2. Review the patch's Twig coding-standards
  3. Review the issue
  4. Review the patch
  5. Write your review
  6. Review your review
  7. Post your review